Fix mathematically incorrect statements about empty sets in set documentation #11855
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation Co-authored-by: eiriktsarpalis <[email protected]>
Copilot
AI
changed the title
Copilot finished work on behalf of
eiriktsarpalis
September 27, 2025 10:44
eiriktsarpalis
approved these changes
Sep 27, 2025
PranavSenthilnathan
requested changes
Oct 2, 2025
dotnet-policy-service
bot
added
the
needs-author-action
…er set types Co-authored-by: PranavSenthilnathan <[email protected]>
dotnet-policy-service
bot
removed
the
needs-author-action
Copilot
AI
changed the title
Copilot finished work on behalf of
PranavSenthilnathan
October 2, 2025 20:35
PranavSenthilnathan
approved these changes
Oct 3, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR corrects mathematically incorrect statements about empty sets in the documentation for various set types' IsProperSubsetOf and IsProperSupersetOf methods. The documentation previously claimed that an empty set is a "proper subset" and "proper superset" of any other collection, which violates set theory principles.
- Removes the word "proper" from statements about empty sets in documentation
- Corrects statements to reflect that an empty set is simply a subset of any other collection
- Maintains consistency across all affected set type documentation
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| xml/System.Collections.Immutable/ImmutableSortedSet`1.xml | Fixed empty set statements in IsProperSubsetOf and IsProperSupersetOf documentation |
| xml/System.Collections.Generic/SortedSet`1.xml | Fixed empty set statements in IsProperSubsetOf and IsProperSupersetOf documentation |
| xml/System.Collections.Generic/ISet`1.xml | Fixed empty set statements in IsProperSubsetOf and IsProperSupersetOf documentation |
| xml/System.Collections.Generic/HashSet`1.xml | Fixed empty set statements in IsProperSubsetOf and IsProperSupersetOf documentation |
gewarren
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The documentation for multiple set types contained mathematically incorrect statements about empty sets:
In
IsProperSupersetOfmethods:In
IsProperSubsetOfmethods:Both statements violate basic set theory principles.
Solution
Corrected all statements to align with mathematical set theory:
Mathematical Background
In set theory:
Change Details
Fixed incorrect statements in the following files:
ImmutableSortedSet`1.xml:
HashSet`1.xml:
SortedSet`1.xml:
ISet`1.xml:
All changes remove the word "proper" from the empty set statements to correctly reflect that an empty set is a subset (not a proper subset or proper superset) of all sets.
Impact
Corrects the mathematical explanations without affecting functionality. The method behavior remains unchanged - the documentation now accurately describes what the methods return.
Fixes #11853
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.